Add FileType and Format testing#45
Open
jooola wants to merge 2 commits intodhowden:masterfrom
jooola:enhance_testing
Open
Add FileType and Format testing#45jooola wants to merge 2 commits intodhowden:masterfrom jooola:enhance_testing
jooola wants to merge 2 commits intodhowden:masterfrom
jooola:enhance_testing
Conversation
Contributor
Author
|
@dhowden How could I fix those few things to get this merged ? |
Owner
|
Apologies! I've been crazy busy. Will try to have a look this week. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Few things need to be fixed before merging :
sample.id3v22.mp3file has id3v23 tags, I could not find a way to write id3v22 tags. HELP !.m4afiles don't return any FileType..mp4but it seems intended.Or maybe the MP4 metadata don't return any FileType at all.